feat(dashboard): integrations update and create flow #7281
Conversation
| </TabsContent> | ||
| <TabsContent value="data-warehouse" variant="regular"> | ||
| <div className="text-muted-foreground flex h-64 items-center justify-center">Coming soon</div> | ||
| </TabsContent> | ||
| </Tabs> | ||
| <Outlet /> |
There was a problem hiding this comment.
to build a nice animation on open and close, you can do a similar thing to what we have in: configure-step-template.tsx plus using the AnimatedOutlet instead of the regular one
There was a problem hiding this comment.
Will skip the added animation for now, but I like the idea!
apps/dashboard/src/components/integrations/components/modals/delete-integration-modal.tsx
Outdated
Show resolved
Hide resolved
| isOpened: boolean; | ||
| }; | ||
|
|
||
| export function CreateIntegrationSidebar({ isOpened }: CreateIntegrationSidebarProps) { |
There was a problem hiding this comment.
something weird is happening when clicking on connect integration
Screen.Recording.2024-12-20.at.09.45.53.mov
There was a problem hiding this comment.
Not able to reproduce, might be some local thing going on. I will deploy this to staging and will see if it's still noticable
apps/dashboard/src/components/integrations/components/integration-general-settings.tsx
Outdated
Show resolved
Hide resolved
| mode: 'create', | ||
| }); | ||
|
|
||
| async function handleCreateIntegration(data: IntegrationFormData) { |
There was a problem hiding this comment.
when the integration is created using the existing identifier we just show the error toast but should additionally mark the field in the form and show the validation error there
There was a problem hiding this comment.
Couldn't find a quick one for this, I don't think it's adds a lot value for the amount of work. Will skip it for now
|
@LetItRock merging to keep testing this out on staging with some legacy data, and cases under a FF |
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer